dataAvailable method backported to 2.4

[rikvdh]

I already did this for 3.0 earlier, now for 2.4

[markstory]

Inline assignments in function calls always look like a mistake. You should assign these variables above the function call and pass them in.

[rikvdh]

@markstory See pull request #1020 ;-)

[dereuromark]

I don't think the initialization is even necessary.
In PHP you can just do stream_select($readFds, $writeFds, $errorFds, $timeout);.
$writeFds, $errorFds will automatically be initialized here as they are merely return variables.

A (small) flaw in PHP itself one could say.

[markstory]

Well I made a mistake last time, these things happen. I'll fix the code in 3.0.

[rikvdh]

I think it the initialization is necessary because these parameters are also a input to this function, by passing uninitialized variables you don't actually know what happens and PHP throws a warning.

From: http://php.net/manual/en/function.stream-select.php

e.g. write: 'The streams listed in the write array will be watched to see if a write will not block.'

which means that (even though its a reference) it still is input.

[dereuromark]

Interesting, I only know if from exec() etc where you don't need to do that. But maybe this method behaves differently.

[markstory]

Based on my local testing, this method like most of the gross C API's in PHP don't need the variables initialized.

<?php
error_reporting(-1);
$fds = array(fopen('php://stdin', 'r'));
$ready = stream_select($fds, $write, $error, 0);

Works fine on my machine without any notice errors.

[rikvdh]

I still don't like it, when the PHP interpreter changes this may give problems, just relying on the default of the interpreter is not the best way to go in my opinion.

[dereuromark]

This behavior is quite unlikely to ever change :)

[rikvdh]

@dereuromark, Yeah I think your right. Still I think its better to init imo. BUT now we saved 2 lines of code!

[dereuromark]

You still need to squash, though.

[rikvdh]

@dereuromark what do you mean?

[dereuromark]

those 5 commits should be merged into a single one by rebasing it upstream and squashing them into a single commit.

[ceeram]

@markstory except that phpcs will complain about Unused variable.

[markstory]

@ceeram That's a separate problem, I can take care of that after the merge.

[rikvdh]

See #1112 :)

[markstory]

See #1112