New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for parseHuge to false to avoid OOM on xml expansion #11094

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
5 participants
@ceeram
Member

ceeram commented Aug 24, 2017

The option was added to allow for enabling (#10034) parseHuge as the docblock also decribes, having this enabled though by default is not recommended.

@ceeram ceeram self-assigned this Aug 24, 2017

@markstory markstory added this to the 3.5.1 milestone Aug 25, 2017

@markstory markstory self-assigned this Aug 25, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 25, 2017

Codecov Report

Merging #11094 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11094      +/-   ##
============================================
+ Coverage     94.87%   94.92%   +0.05%     
- Complexity    12838    13059     +221     
============================================
  Files           437      437              
  Lines         32732    33060     +328     
============================================
+ Hits          31053    31381     +328     
  Misses         1679     1679
Impacted Files Coverage Δ Complexity Δ
src/Utility/Xml.php 100% <ø> (ø) 73 <0> (ø) ⬇️
src/Http/ActionDispatcher.php 100% <0%> (ø) 21% <0%> (+2%) ⬆️
src/Controller/Controller.php 99.53% <0%> (+0.07%) 102% <0%> (+25%) ⬆️
src/Http/ServerRequest.php 99.65% <0%> (+0.16%) 432% <0%> (+194%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64e0a9...e9fdee3. Read the comment docs.

codecov-io commented Aug 25, 2017

Codecov Report

Merging #11094 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11094      +/-   ##
============================================
+ Coverage     94.87%   94.92%   +0.05%     
- Complexity    12838    13059     +221     
============================================
  Files           437      437              
  Lines         32732    33060     +328     
============================================
+ Hits          31053    31381     +328     
  Misses         1679     1679
Impacted Files Coverage Δ Complexity Δ
src/Utility/Xml.php 100% <ø> (ø) 73 <0> (ø) ⬇️
src/Http/ActionDispatcher.php 100% <0%> (ø) 21% <0%> (+2%) ⬆️
src/Controller/Controller.php 99.53% <0%> (+0.07%) 102% <0%> (+25%) ⬆️
src/Http/ServerRequest.php 99.65% <0%> (+0.16%) 432% <0%> (+194%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64e0a9...e9fdee3. Read the comment docs.

@markstory markstory merged commit 2222034 into master Aug 25, 2017

6 checks passed

codecov/patch Coverage not affected when comparing 3587231...e9fdee3
Details
codecov/project 94.92% (+0.05%) compared to 3587231
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the xml-expansion branch Aug 25, 2017

@inoas

This comment has been minimized.

Show comment
Hide comment
@inoas

inoas Aug 28, 2017

Contributor

Doesn't look BC to me, is it?

Contributor

inoas commented Aug 28, 2017

Doesn't look BC to me, is it?

@ceeram

This comment has been minimized.

Show comment
Hide comment
@ceeram

ceeram Aug 28, 2017

Member
Member

ceeram commented Aug 28, 2017

@ravage84

This comment has been minimized.

Show comment
Hide comment
@ravage84

ravage84 Aug 29, 2017

Member

@markstory This should be shown very prominently in the release notes, then. So pepole don't trip over it.

Member

ravage84 commented Aug 29, 2017

@markstory This should be shown very prominently in the release notes, then. So pepole don't trip over it.

@ceeram

This comment has been minimized.

Show comment
Hide comment
@ceeram

ceeram Aug 29, 2017

Member

I doubt if many users will trip. First off, Most users don't use Xml, those that do use it would only need parseHuge in edge cases. The docs already stated to set parseHuge option to true, even though the code itself didnt need it, because of the default. So most likely for those edge cases people are passing the parseHuge option as true already.

Member

ceeram commented Aug 29, 2017

I doubt if many users will trip. First off, Most users don't use Xml, those that do use it would only need parseHuge in edge cases. The docs already stated to set parseHuge option to true, even though the code itself didnt need it, because of the default. So most likely for those edge cases people are passing the parseHuge option as true already.

@ravage84

This comment has been minimized.

Show comment
Hide comment
@ravage84

ravage84 Aug 29, 2017

Member

@ceeram thanks for the clarification.

Member

ravage84 commented Aug 29, 2017

@ceeram thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment