Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed binary column length not being returned by SqliteSchema & MysqlSchema #12518

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

dmromanov
Copy link
Contributor

@dmromanov dmromanov commented Aug 30, 2018

Fixed binary column length not being returned by SqliteSchema & MysqlSchema.

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #12518 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12518      +/-   ##
============================================
+ Coverage     91.94%   91.95%   +<.01%     
  Complexity    13555    13555              
============================================
  Files           467      467              
  Lines         34847    34847              
============================================
+ Hits          32040    32043       +3     
+ Misses         2807     2804       -3
Impacted Files Coverage Δ Complexity Δ
src/Database/Schema/SqliteSchema.php 99.56% <100%> (ø) 82 <0> (ø) ⬇️
src/Database/Schema/MysqlSchema.php 98.93% <100%> (ø) 115 <0> (ø) ⬇️
src/Cache/Engine/FileEngine.php 90.1% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4.16%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898ce46...6657c22. Read the comment docs.

@dmromanov dmromanov changed the title Fixed binary column length not being returned by SqliteSchema Fixed binary column length not being returned by SqliteSchema & MysqlSchema Aug 30, 2018
@markstory markstory self-assigned this Aug 30, 2018
@markstory markstory merged commit f99680b into cakephp:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants