fix select hours for 0/12 #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this probably the most problematic line in CakePHP |
|
Yeah, probably. Would it be better to cast to int right away? |
| @@ -2207,7 +2207,7 @@ public function hour($fieldName, $format24Hours = false, $attributes = array()) | |||
| if ($attributes['value'] > 12 && !$format24Hours) { | |||
| $attributes['value'] -= 12; | |||
| } | |||
| if ($attributes['value'] === '00' && !$format24Hours) { | |||
| if (($attributes['value'] === 0 || $attributes['value'] === '00') && !$format24Hours) { | |||
There was a problem hiding this comment.
Would a loose equality to 0 be more durable in the long run?
|
An int cast is probably the best option imo. |
|
I did some quick tests locally and an int cast is a bad idea, as '', null and false all match at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for hour 12 (e.g. local time 14 at UTC+2) the tests fail as
-= 12casts to 0 and the=== '00'check is not triggered.see http://ci.cakephp.org/job/CakePHP%202.3%20-%20MySQL/993/ etc