Show notice for non existent controller property.

[ADmad]

Refs #12590 (comment)

[garas]

Maybe reverse if and explain:

if ($class === $name) {
   // Autoload table if $name matches controller name
   return $this->loadModel($plugin . $class);
}

// notice

return false; // remove or explicitly return null at 4.x

[markstory]

Looks like we have a few undefined properties being used by our tests 😢

[ADmad]

Not really, the error doesn't make sense. It's complaining about missing Controller::$viewClass but that property is available through the ViewVarsTrait.

[garas]

Controller::$viewClass is defined in ViewVarsTrait, but it is unset() after first use.

#12035 I've added an unset() for viewClass to avoid a permanent deprecation warning when RequestHandlerComponent is used.

cakephp/src/View/ViewVarsTrait.php

Lines 75 to 78 in 13ab4d7

	if ($viewClass === null && $builder->getClassName() === null) {
	$builder->setClassName($this->viewClass);
	unset($this->viewClass);
	}

If second render() tries access value, it is no more available. It should probably leave property set.

[ADmad]

@garas Good find, I'll adjust the code to mitigate this.

[ADmad]

PHPUnit\Framework\Error\Notice is not available in phpunit 5.7 🙁

[garas]

Add alias in tests/phpunit_aliases.php

[ADmad]

Meh, took care of it with a class_exists() check.