Strips the base off the generated URL from the AuthComponent. #1451
Conversation
|
👍 |
| @@ -1269,6 +1269,39 @@ public function testRedirectSessionReadEqualToLoginAction() { | |||
| } | |||
|
|
|||
| /** | |||
| * test that the base is handled correctly. | |||
There was a problem hiding this comment.
"correctly" is a bit too general for my taste, why not explain it slightly more? A few keywords, even a sa list in the long description of the block would be fine.
Additionally/Alternatively you could also link to the lighthouse ticket:
https://cakephp.lighthouseapp.com/projects/42648-cakephp/milestones
There was a problem hiding this comment.
I agree, the docblock is useless. To be honest, I never use docblocks in my tests. Usually I make the method name as descriptive as possible. Then I will be able to easily comment out all the other tests, so that the tests run faster and output is limited. I don't see how a docblock helps a test, because the test tests usage of something.
Anyway, I'll put something better there. I am not going to put the link to the ticket there. Links die.
There was a problem hiding this comment.
it's a small test, so it's fairly easy to scan - the real value of test docblocks is when things get really hairy, or the problem is really complex. This test is so simple it should be easy for everyone to scan and understand in conjunction with the test method name imo
There was a problem hiding this comment.
Oh sh** gave you the wrong link:
https://cakephp.lighthouseapp.com/projects/42648/tickets/3922-authcomponentredirecturl-prepends-appbaseurl
Guess you understood anyway ;-)
I would do the opposite even though the true fact that links die.
The point of linking the tests to a ticket is to keep "the history" of things together.
We already have a few tests with which are linked to lighthouse.
I don't know if there is a official policy about that though...
There was a problem hiding this comment.
The commit message already has the ticket number "Fixes #3922" so one get the url if required.
|
👍 |
Strips the base off the generated URL from the AuthComponent.
| * | ||
| * @see https://cakephp.lighthouseapp.com/projects/42648/tickets/3922-authcomponentredirecturl-prepends-appbaseurl | ||
| * | ||
| * @return void This test method doesn't return anything. |
|
Thanks for taking care of this 👍 |
Fixes #3922.
Reference: https://cakephp.lighthouseapp.com/projects/42648/tickets/3922-authcomponentredirecturl-prepends-appbaseurl