Update JqueryEngineHelper.php

[Tzaoh]

I hope this one is correct.
Because this a feature request it should go on cakephp 2.6 branch.

I would like being able to specify more then one id to be called when updated after an ajax request.
I know it is also possible accomplish this, wrapping all tags with and external tag, but I want to have both options.

Due compatibility with apps already coded it checks if parameter is not an array

I was asked to build a Test case to back my change, so instead of using an string to indicate the following call that we want to update just the tag whose have the specified id we do this:

<?=
    $this->Js->submit(
        __('Update'),
        array(
            'async'             =>  true,
            'class'             =>  'btn btn-default',
            'div'               =>  array(
                'class'         =>  'form-group'
            ),
            'method'            =>  'get',
            'update'            =>  array('#id_1', '#id_2'),
            'url' => array(
                'controller'    =>  'players',
                'action'        =>  'get_player/' . $name
            )
        )
    );
?>

Please let me know if I should improve any part of my pull. Thanks for your patience.

[dereuromark]

If you cast, you can avoid the if/else and the is_array() check completely:

$elements = (array)$options['update'];
foreach (...) {}

done :)

[Tzaoh]

You are right, much better this way.
Thank you!

[dereuromark]

Why did you close? You can directly push your changes here on the same branch. This PR will then be updated automatically.

[bcrowe]

@Tzaoh To do what @dereuromark mentioned, go to your fork on GitHub, select your patch-1 branch from the dropdown, and continue to use the GitHub online editor. This will continue to add commits to this PR.

[Tzaoh]

Oh sorry, he wrote "done :)" and i thought he will commit it.
I try to do it now.
Sorry for your headaches guys ^^

[markstory]

Could we get a test for whatever this is fixing?

[Tzaoh]

Hello @markstory , the modification of the last patch is because the first version of it was less optimized than casting as @dereuromark pointed. This way is more more clear and efficient.
I am not sure if your message is to me. If that is the case how should I send you a test case which only involves "optimization"?

Thank you

[dereuromark]

The issue is still the same as in your previous PR: there is no test case that goes along your changes.
To make things clear: A test with an array of "update"s ;)

[Tzaoh]

Hello, @dereuromark , is not enough with the code I posted on first comment?
Should I attach a ctp file?

[dereuromark]

Maybe one of us can add the test for 'update' => array('#id_1', '#id_2'), if he can't do it.

[ADmad]

Why are we adding features to an engine when JsHelper and all its engines are already removed in 3.0? :) Imo we should encourage people to directly write js code.

[dereuromark]

For the live line of 2.x this is still an included (and used) class - no matter how deprecated.
If someone wants to provide additional functionality or a bugfix this should probably not be ignored then. Especially if he is able to produce it on its own.

@Tzaoh He has a point, though, you should start using plain JS or write your own plugin solutions for this in the future if possible.

[dereuromark]

@Tzaoh Would you be able to modify your PR with the suggested changes (missing test case should be added for how to need the array here)?
Then we can fit it into the 2.6 release.

[markstory]

Closing as its been quite a while with no updates. @Tzaoh if you find the time to add the test cases, let us know and we can get the changes merged in.