Add StringExpression with collation support #15040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
string-expression
branch
from
f9b2843
to
bc979bb
Compare
othercorey
force-pushed
the
string-expression
branch
2 times, most recently
from
daa7fec
to
3bd087e
Compare
othercorey
force-pushed
the
string-expression
branch
2 times, most recently
from
14030ae
to
25419f9
Compare
othercorey
commented
Oct 11, 2020
src/Database/Driver/Postgres.php
Outdated
| { | ||
| $collation = $expression->getCollation(); | ||
| if ($collation) { | ||
| $expression->setCollation('"' . trim($collation, '"') . '"'); |
There was a problem hiding this comment.
The trim() works around a design flaw where expressions are transformed every time sql() is called. I don't know how to fix that in 4.2.
othercorey
force-pushed
the
string-expression
branch
5 times, most recently
from
b4b52f9
to
71cab62
Compare
ADmad
reviewed
Oct 11, 2020
othercorey
force-pushed
the
string-expression
branch
from
774d9e3
to
06c680e
Compare
othercorey
force-pushed
the
string-expression
branch
2 times, most recently
from
680c5b0
to
3636673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #14546
Query::newString()helps simplify code instead of having to callednew StringExpressioneverywhere.If we want to support changing the collation of columns in an expression, that should be done through
IdentifierExpression.