Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 view #1642

Merged
merged 2 commits into from
Sep 17, 2013
Merged

3.0 view #1642

merged 2 commits into from
Sep 17, 2013

Conversation

dereuromark
Copy link
Member

Resolves https://cakephp.lighthouseapp.com/projects/42648/tickets/2449-view-folder-name-conflicts

Basically it renames all folder names in View that could potentially conflict with user-land Controller names (and their respective folder names following convention):

  • Emails => Email
  • Layouts => Layout
  • Elements => Element
  • Scaffolds => Scaffold
  • Errors => Error

I will update the migration guide and docs afterwards.

@@ -12,7 +12,7 @@
*
* @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
* @link http://cakephp.org CakePHP(tm) Project
* @package app.View.Errors
* @package app.View.Error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package tags should just be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do that globally in a separate PR for all files then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been doing it piecemeal so the giant commit is smaller in the future.

@markstory
Copy link
Member

This will need to be matched with a pull request against cakephp/app and the docs as well.

@markstory
Copy link
Member

An upgrade shell command would be ideal for this as well :-)

@dereuromark dereuromark mentioned this pull request Sep 15, 2013
@dereuromark
Copy link
Member Author

@markstory Couldn't we add those to the existing upgrade command locations()?

@markstory
Copy link
Member

Yeah updating the locations command is probably a better idea.

@dereuromark
Copy link
Member Author

I will address the @package removal in a separate and complete PR. Anything else or is this (and its related two PRs) good to go?

@markstory
Copy link
Member

I think this and the related changes good to go. Any thoughts @lorenzo

@lorenzo
Copy link
Member

lorenzo commented Sep 17, 2013

It looks good to me, good job @dereuromark !

lorenzo added a commit that referenced this pull request Sep 17, 2013
@lorenzo lorenzo merged commit 8858a62 into cakephp:3.0 Sep 17, 2013
@lorenzo
Copy link
Member

lorenzo commented Sep 17, 2013

@dereuromark would be nice to add this changes to the migration guide in the book

@dereuromark
Copy link
Member Author

All done in the related and referenced PRs, you just haven't merged em yet :)

@josephzidell
Copy link

Are views working in 3.0? I'm getting a 500 error on a simple action/view

@markstory
Copy link
Member

Did you move your files around? You'll need to update your app skeleton for it to work with current 3.0.

@josephzidell
Copy link

I'm working with a 3.0 download

@markstory
Copy link
Member

I just merged a pull request in cakephp/app that moves the directories around.

@josephzidell
Copy link

I did a git pull but nothing happened.

@markstory
Copy link
Member

Remember that both the directory and App.paths.templates config variable need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants