-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 view #1642
3.0 view #1642
Conversation
@@ -12,7 +12,7 @@ | |||
* | |||
* @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org) | |||
* @link http://cakephp.org CakePHP(tm) Project | |||
* @package app.View.Errors | |||
* @package app.View.Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package tags should just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do that globally in a separate PR for all files then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been doing it piecemeal so the giant commit is smaller in the future.
This will need to be matched with a pull request against cakephp/app and the docs as well. |
An upgrade shell command would be ideal for this as well :-) |
@markstory Couldn't we add those to the existing upgrade command |
Yeah updating the locations command is probably a better idea. |
I will address the |
I think this and the related changes good to go. Any thoughts @lorenzo |
It looks good to me, good job @dereuromark ! |
@dereuromark would be nice to add this changes to the migration guide in the book |
All done in the related and referenced PRs, you just haven't merged em yet :) |
Are views working in 3.0? I'm getting a 500 error on a simple action/view |
Did you move your files around? You'll need to update your app skeleton for it to work with current 3.0. |
I'm working with a 3.0 download |
I just merged a pull request in cakephp/app that moves the directories around. |
I did a |
Remember that both the directory and App.paths.templates config variable need to change. |
Resolves https://cakephp.lighthouseapp.com/projects/42648/tickets/2449-view-folder-name-conflicts
Basically it renames all folder names in View that could potentially conflict with user-land Controller names (and their respective folder names following convention):
I will update the migration guide and docs afterwards.