Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for url input #169

Merged
merged 3 commits into from
Aug 10, 2011
Merged

Adding support for url input #169

merged 3 commits into from
Aug 10, 2011

Conversation

kamui545
Copy link
Contributor

@kamui545 kamui545 commented Aug 9, 2011

@ADmad
Copy link
Member

ADmad commented Aug 9, 2011

How about this 1liner instead: $input = $this->text($fieldName, array('type' => 'url') + $options); Keeps things a bit more DRY as you don't repeat the code that's in __call()

@kamui545
Copy link
Contributor Author

kamui545 commented Aug 9, 2011

Looks good :) Thx !

@ADmad
Copy link
Member

ADmad commented Aug 9, 2011

You could add a test case too. :)

@kamui545
Copy link
Contributor Author

kamui545 commented Aug 9, 2011

Done :P

ADmad added a commit that referenced this pull request Aug 10, 2011
@ADmad
Merge pull request #169 from kamui545/patch-1
8d8d64a 
Adding support for url input
@ADmad ADmad merged commit 8d8d64a into cakephp:2.0 Aug 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamui545 @ADmad