Adding Collection::compile as a way to optimize operations with a single collection #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * $allButJohn = $compiled->filter($johnMatcher); | ||
| * }}} | ||
| * | ||
| * In the above example, had not the collection compiled before, the iterations |
There was a problem hiding this comment.
'had the collection not been compiled before'
lorenzo
added a commit
that referenced
this pull request
Dec 29, 2013
Adding Collection::compile as a way to optimize operations with a single collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the talk in IRC about streaming results I thought it would be nice to consolidate all results from an internal iterator into another collection. Also, I realized that by nesting iterators there would be a chance of wasting CPU by calculating stuff twice if the same variable is used.
This introduces
Collection::compile(), a way of copying the results of toArray() from a collection into a new one in order to consolidate internal operations and to easily make iterators that would not rewind, rewindable