3.0 FormHelper submit #2943
Merged
3.0 FormHelper submit #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have been systematically removed from the helper. They have been replaced everywhere with templates.
Templates should be used instead.
| $options['name'] . '_x', $options['name'] . '_y' | ||
| ); | ||
| $unlockFields = [ | ||
| $options['name'] . '_x', |
There was a problem hiding this comment.
Do you remember what wa the purpose of this?
There was a problem hiding this comment.
I do! Image submits post 2 values instead of 1. They submit the x & y co-ordinates the user clicked on the image. When we're dealing with secured forms we need to hash the fields we'll get in the end.
There was a problem hiding this comment.
Shows how long it's been since using image submits has gone out of fashion 😛
There was a problem hiding this comment.
Whatever, image submits 4 lyfe!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2267. When the tests for this method were re-enabled the method was not cleaned up and made consistent with other parts of the helper. These changes help address that and make the submit() method use templates like other parts of FormHelper.