adding Context to CakeSocket #334
Conversation
cakephp#2270 adding Context to CakeSocket and HTTP Socket. Changing CakeSocket from fsockopen to stream_socket_client allows giving the connection an context. the default behavior is: if the connection is secure we get the certificate, parse it and deliver it with the http-response object.
|
#2270 adding Context to CakeSocket and HTTP Socket. Changing CakeSocket |
|
I'm not sure what is this trying to fix. using the CakeSocket class with the ssl:// protocol already works. can you explain this a little bit more? |
|
of course cake socket works with ssl, but it does not give the context back (esp. the ssl cert for checking if we are communicating with the right server). the change is, we now get the certificate back and deliver it in the resonse object to the application. |
|
for more infos about this issue: http://cakephp.lighthouseapp.com/projects/42648/tickets/2270-connection-missing-in-cakesocket |
|
Shouldn't you be checking for the |
|
good point. i'll check this. |
|
i am getting crazy, but github did not let me update my request. |
|
You should be able to push to the original branch you pushed to. Github will automatically update the pull request. |
check if openssl is installed by if php know openssl functions.
|
don't know why the change did not appear here, but now it does (and also my earlier changes). |
|
|
||
|
|
||
| public function checkFingerprint($fingerprint){ | ||
| if (!isset($this->request['context']['ssl']['peer_certificate'])) |
added missing branches
ghost
assigned 
|
Closing in favor of #947 |
#2270 adding Context to CakeSocket and HTTP Socket. Changing CakeSocket
from fsockopen to stream_socket_client allows giving the connection an
context. the default behavior is: if the connection is secure we get
the certificate, parse it and deliver it with the http-response object.