3.0 Fix failing tests when there is no network #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete tests that were testing features that no longer exist in TestCase. Unskip tests that now work.
| @@ -383,8 +382,12 @@ public function testGetContext() { | |||
| 'ssl' => array('capture_peer' => true) | |||
| ) | |||
| ); | |||
| try { | |||
| $this->Socket = new Socket($config); | |||
There was a problem hiding this comment.
The indentation here looks incorrect.
|
Test failures seem to be related to timing and not the changes I made. |
lorenzo
added a commit
that referenced
this pull request
May 22, 2014
3.0 Fix failing tests when there is no network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing tests when the network is disabled, also remove some incomplete test markers as the tests pass, or are no longer required.