Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2 resourcesprefix #763

Closed
wants to merge 3 commits into from
Closed

2.2 resourcesprefix #763

wants to merge 3 commits into from

Conversation

ceeram
Copy link
Contributor

@ceeram ceeram commented Aug 9, 2012

Enable admin (or other configured routing prefixes) for mapResources()

@markstory
Copy link
Member

Would you want prefixed resource routes without the prefix in the URL? How does this interact with normal web requests? Seems like in the example of the tests /posts would actually be an admin method, which isn't clear. Could we do something smarter like also set the prefix option based on the routing prefix if the classic prefix option is undefined? That is similar to the reworked mapResources() + prefixes in 3.0

@ceeram
Copy link
Contributor Author

ceeram commented Aug 9, 2012

I did this work after someone on irc needing to map to admin methods, i
know in 3.0 this will all change drasticly, perhaps not add things in 2.x
that will changed again in 3.x. I can close the PR if you'd rather not
implenent this
Op 9 aug. 2012 22:19 schreef "Mark Story" notifications@github.com het
volgende:

Would you want prefixed resource routes without the prefix in the URL? How
does this interact with normal web requests? Seems like in the example of
the tests /posts would actually be an admin method, which isn't clear.
Could we do something smarter like also set the prefix option based on
the routing prefix if the classic prefix option is undefined? That is
similar to the reworked mapResources() + prefixes in 3.0


Reply to this email directly or view it on GitHubhttps://github.com//pull/763#issuecomment-7625724.

@markstory
Copy link
Member

Well I was more wondering if we could add this and emulate the behavior in 3.0. I think its possible to do so if a routing prefix is provided and the existing prefix option is not used.

@ceeram
Copy link
Contributor Author

ceeram commented Aug 10, 2012

@markstory would that emulating include the static prefix which overrides the plugin prefix in url for 3.0?

@lorenzo
Copy link
Member

lorenzo commented Dec 22, 2012

Are we still interested in supporting this?

@ceeram
Copy link
Contributor Author

ceeram commented Dec 22, 2012

I think it can be closed
Op 22 dec. 2012 23:29 schreef "José Lorenzo Rodríguez" <
notifications@github.com> het volgende:

Are we still interested in supporting this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/763#issuecomment-11642018.

@lorenzo lorenzo closed this Dec 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants