Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The actual config file must always have .php extension. #772

Merged
merged 1 commit into from
Aug 16, 2012

Conversation

bar
Copy link
Contributor

@bar bar commented Aug 13, 2012

@ADmad
Copy link
Member

ADmad commented Aug 13, 2012

The file lib/Cake/Test/test_app/Config/var_test3 isn't needed right?

You don't need to make new pull requests each time. You can just amend your commit and the PR will be automatically updated.

@bar
Copy link
Contributor Author

bar commented Aug 13, 2012

Sorry for that one! I'm a git (full time console) user :P

It is necessary to exist and have a $config var inside, but the contents of $config doesn't matter, I just left them there for the people to understand that it is a perfectly valid config file but won't work as it does not end with .php.

If this is good to go, I'll update IniReader accordingly.

@markstory
Copy link
Member

I think this one is good to go.

@bar
Copy link
Contributor Author

bar commented Aug 13, 2012

Nice, should I update IniReader with the same behavior so it understands plugins?

@markstory
Copy link
Member

Yeah, having both work the same would be ideal. I can't believe I missed the plugin support for IniReader when it was added for PhpReader :(

@bar
Copy link
Contributor Author

bar commented Aug 14, 2012

You can't be everywhere Mark! Let some fun for us :P

markstory added a commit that referenced this pull request Aug 16, 2012
The actual config file must always have .php extension.
@markstory markstory merged commit 08e4362 into cakephp:master Aug 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants