Added identiferEquals method for expressions to use fields with quoti… #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in join conditions. Added identifier parameter for expressions.
| */ | ||
| public function equalFields($left, $right) | ||
| { | ||
| return $this->eq(new IdentifierExpression($left), new IdentifierExpression($right)); |
There was a problem hiding this comment.
I think we we should test for $left and $right not being ExpressionInterface before wrapping them in an identifier expression
| { | ||
| $wrapIdentifier = function ($field) { | ||
| if ($field instanceof ExpressionInterface) { | ||
| return $field; |
There was a problem hiding this comment.
Do any of the tests get in here?
There was a problem hiding this comment.
Yes, Query tests cover this method.
|
This looks good to me. Any thoughts @lorenzo ? |
|
Woops, I thought it was merged already |
lorenzo
added a commit
that referenced
this pull request
Feb 15, 2016
Added identiferEquals method for expressions to use fields with quoti…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng in join conditions. Added identifier parameter for expressions. Request created against master to replace #8238