Fix for 'Uninitialized string offset: 0' when using Request's referer under PHP 7

[elboletaire]

Fixes #8794

As said in the issue, I'm not sure about how I've fixed it. But let me know what could I change to improve it.

[elboletaire]

Now I like it better. Let me know what do you think 😃

[codecov-io]

Current coverage is 92.89%

Merging #8795 into master will increase coverage by +<.01%

@@             master      #8795   diff @@
==========================================
  Files           363        363          
  Lines         27141      27143     +2   
  Methods        3206       3206          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          25212      25214     +2   
  Misses         1929       1929          
  Partials          0          0          

Powered by Codecov. Last updated by 6a463bb...c826a2b

[ADmad]

This issue looks similar to the fix done for 2.x 3ad68db

That code looks much cleaner.

[elboletaire]

Yup, seems exactly the same issue. With that code you mean the one by @markstory, right?

If so, let me change it.

[ADmad]

Yes I meant the code in commit I linked :)

[elboletaire]

Done :)

[ADmad]

Please squash the commits.

[elboletaire]

Sure. BTW, on my first commit I was checking for empty and wasn't necessary. Something like this would be enough:

$ref = substr($ref, strlen($base)) ?: '/';
if ($ref[0] !== '/') {
    $ref = '/' . $ref;
}

pd. I'm squashing

[elboletaire]

Done :)

[markstory]

Perhaps we should use strlen()? empty() eats '0'.

[elboletaire]

Yup, you're right. I've changed it in a52a8d1 adding an assertion for it too.

[markstory]

Thanks 👍

[elboletaire]

You're welcome, as always! 😃