default value null makes more sense. add test cases for false. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have any objections, but I don't understand why that argument even has a default value actually. What utility does |
|
actually why is first argument set to false as default? |
+1 to this question |
|
good question! i will then remove the = null part as it really makes no sense at all. |
|
why is the merge status always failing?... |
|
travis seems to have borked its php setup again. |
|
;) ok, thought I did sth wrong with the setup. |
|
This looks good to me. |
markstory
added a commit
that referenced
this pull request
Oct 14, 2012
default value null makes more sense. add test cases for false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most people would expect null as default value. any objections?