Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

default value null makes more sense. add test cases for false. #899

Merged
merged 2 commits into from Oct 14, 2012

Conversation

Projects
None yet
4 participants
Member

dereuromark commented Oct 12, 2012

most people would expect null as default value. any objections?

Owner

markstory commented Oct 12, 2012

I don't have any objections, but I don't understand why that argument even has a default value actually. What utility does debug() with no arguments even serve?

Owner

lorenzo commented Oct 12, 2012

actually why is first argument set to false as default?

Member

ADmad commented Oct 12, 2012

What utility does debug() with no arguments even serve?

+1 to this question

Member

dereuromark commented Oct 12, 2012

good question! i will then remove the = null part as it really makes no sense at all.

Member

dereuromark commented Oct 12, 2012

why is the merge status always failing?...

Member

ADmad commented Oct 12, 2012

travis seems to have borked its php setup again.

Member

dereuromark commented Oct 12, 2012

;) ok, thought I did sth wrong with the setup.

Owner

markstory commented Oct 14, 2012

This looks good to me.

@markstory markstory added a commit that referenced this pull request Oct 14, 2012

@markstory markstory Merge pull request #899 from dereuromark/2.3-more-tests
default value null makes more sense. add test cases for false.
7ea3ee4

@markstory markstory merged commit 7ea3ee4 into cakephp:2.3 Oct 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment