-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorry, wrong branch :( #9024
Closed
Closed
Sorry, wrong branch :( #9024
Changes from all commits
Commits
Show all changes
329 commits
Select commit
Hold shift + click to select a range
bff49bd
Added tests for all expression that are capable of accepting
lorenzo a4c1222
Adding doc blocks and fixing some failing tests
lorenzo a5e410c
Renamed trait
lorenzo 770016d
Using the new trait and simplifying code
lorenzo 838c5fd
Fix typos in doc blocks.
markstory 799c7c2
Making sure ValuesExpression also casts values to expressions
lorenzo 3cbb89c
It turns out that SQLite 3.7.11+ implements multi-inserts!
lorenzo cb42f90
Adding integration test for the Type to expression casting
lorenzo 1b00624
Simplifying code
lorenzo 2e3782e
Making tests pass in postgresql
lorenzo 17c3bef
Adding a function traslator for the SUBSTR function in SQL Server
lorenzo 480a1f0
Fixed CS
lorenzo 6dc1b3f
Fix up typos and add doc blocks.
markstory f52cea8
More CS fixes
lorenzo e248f6f
Add argument support for detectors
jadb 3cc3074
Add new argument to docblock
jadb 64ec05c
Missing templates should raise exceptions.
markstory 73cafe7
Revert "Missing templates should raise exceptions."
markstory 71c5e98
Missing templates should raise exceptions.
markstory ce76580
Merge pull request #8492 from CVO-Technologies/email-subject-decode
lorenzo bb014d2
Merge branch 'master' into 3.next
markstory 9ffc1de
Merge branch '3.next' of github.com:cakephp/cakephp into 3.next
markstory c3256ab
Merge pull request #8550 from cakephp/3.3-request-detectors-arguments
markstory 26591df
Merge pull request #8555 from cakephp/issue-8554
markstory 67c7d95
Merge branch 'master' into 3.next
markstory 0b92431
Added test for value object in conditions
lorenzo 1aba0c3
Merge branch 'master' into 3.next
markstory e5632f3
Merge branch 'master' into 3.next
markstory 5541862
Merge pull request #8526 from cakephp/expression-types
lorenzo 82d6fcf
Add MiddlewareStack.
markstory 1c068b4
Fix import ordering.
markstory 2f37224
Get 100% coverage!
markstory b89a845
Implement the middleware runner.
markstory 4e685e6
Merge pull request #8590 from cakephp/middleware-stack
lorenzo bc18e90
Merge remote-tracking branch 'origin/master' into 3.next
lorenzo 1c2a9d9
allow requirePresence to pass array to validate multiple fields
Graziel 219f22a
doc block update
Graziel ed8cbc1
Add RequestFactory and RequestTransformer.
markstory 9fbb51f
Fix PHPCS errors.
markstory 1e2e0ab
Merge remote-tracking branch 'origin/master' into 3.next
lorenzo d2828ff
Merge pull request #8599 from cakephp/middleware-runner
lorenzo 91799c4
Merge branch 'master' into 3.next
markstory 5fb587b
Don't output two welcome messages.
markstory 35c51bb
fix grammar
Graziel 7243769
i should double read mail first : )
Graziel 9989334
Added option to check for NULL values on IsUnique
466ecf9
added tests
JayPHP 3a6372e
added tests + corrections
JayPHP 621c410
Removed note
JayPHP b8ab699
Removed whitespace
JayPHP 36c7d1c
Added whitespace
JayPHP 0aced1a
Corrected uppercase and formatting issues
JayPHP 3913bc0
Fix CS errors.
ADmad a6f3ee8
Merge pull request #8622 from cakephp/request-transformer
lorenzo ac7a912
Add the ResponseTransformer
markstory 13adf44
Fixed CS error
lorenzo a79ff82
Fixed another CS error
lorenzo 7a59f20
Changed option name
c453418
Using pre-existing fixture + CS Fix
6fb1641
Added back tags fixture
be6c1f2
Merge pull request #8623 from cakephp/response-transformer
lorenzo 7974693
Changed name to allow instead of permit
9ecb20a
Merge pull request #8609 from cakephp/less-welcome
markstory 88138af
Merge pull request #8621 from JayPHP/checkNull_on_IsUnique
lorenzo 7c68802
Merge pull request #8601 from Graziel/requirePresence_array
lorenzo 71ac75f
Add standalone ControllerFactory.
markstory cce106b
Remove duplicate code.
markstory 389415f
Fix failing tests.
markstory 50dcf3b
Disallow controller names with / in them.
markstory 553bd5d
Merge pull request #8643 from cakephp/controller-factory
lorenzo 71623f5
Add ActionDispatcher to new Http lib
markstory 5a90c3d
Add constructor injection for the eventManager.
markstory 268de40
Integrate the new ActionDispatcher into Dispatcher
markstory 366484c
Don't double bind dispatch filters.
markstory d65fd83
Fix error message.
markstory 023cf73
Fix test for error message...
markstory cb642f3
Change date's default json encode format to valid ISO8601.
ADmad 7c104a9
#8671 Improving Table::findOrCreate()
656adb7
#8687 Minor code improvements
99c05d9
Run travis job on php nightly to get newer ICU lib.
ADmad bef8694
Fix doc block tag.
markstory 90ce428
Merge pull request #8667 from cakephp/action-dispatcher
markstory 3c75006
Skip datetime string formatting test for old ICU.
ADmad 91234f4
Add Server and BaseApplication.
markstory 3d61835
Use already available INTL_ICU_VERSION constant.
ADmad 87ba9c7
Merge pull request #8685 from cakephp/datetime-jsonencode
markstory 9651600
Update comments based on peer feedback.
markstory 4697b8e
Merge branch 'master' into 3.next
markstory 8b36769
Removing the useless string callback from the findOrCreate
1130d27
Updating the doc block for findOrCreate
5d866f0
Move Http\Client into Http package.
markstory 78be1ec
Make return value of Controller:referer() consistent when returning l…
ADmad 85bd4ed
#8671 Adding documentation and another assert.
4e515b4
Remove un-necessary imports.
markstory bb1ed0f
Merge pull request #8710 from cakephp/controller-referrer
markstory c379ad2
Merge pull request #8696 from cakephp/psr-server
lorenzo fbf3de3
Add ErrorHandling Middleware
markstory 65c36e5
Don't autoload aliased classes.
markstory 50dabae
Instead of triggering a fatal error, modify the response.
markstory 6cda83e
Revert "Don't autoload aliased classes."
markstory d618bfb
Merge pull request #8722 from cakephp/error-middleware
lorenzo 3ed6b06
Merge branch 'master' into 3.next
lorenzo e80d765
Move backwards compatible shims.
markstory 637b994
Implement a PSR7 routing middleware
markstory c8edd81
Load fixtures to fix failing tests.
markstory bdf965d
Fix PHPCS error.
markstory 590d135
Making jsonSerialize be called recursively in entities
lorenzo 74e70e6
Merge pull request #8709 from cakephp/psr7-client
lorenzo d553414
Move aliases to compatbility shims.
markstory aa1eb13
Merge pull request #8751 from cakephp/alias-stubs
lorenzo 8553f1e
Fixed CS error
lorenzo c6c1888
Merge pull request #8745 from cakephp/routing-middleware
lorenzo 6ba01e8
Merge branch 'master' into 3.next
ADmad 4b9095c
Read schema defaults when generating field using EntityContext.
ADmad 35af288
Fix issue when providing explicit default value for input.
ADmad e84a83d
Update signature of `ContextInterface::val()`
ADmad edbb319
Update signature of NullContext::val().
ADmad 2c07444
Merge pull request #8707 from burzum/feature/find-or-create
lorenzo cc9271b
Merge pull request #8750 from cakephp/recursive-to-json
markstory fee6746
Add AssetMiddleware
markstory 4de7bae
Move middleware into more relevant packages.
markstory fccfc6e
Add ability to define model factories statically
Marlinc ed4d394
Merge pull request #8713 from CVO-Technologies/model-factory-static
lorenzo f884130
Remove unused use statement from bootstrap
Marlinc c262b9b
Merge pull request #8771 from CVO-Technologies/model-factory-static
markstory 1b0a9ce
Fix use ordering.
markstory b4e4f99
Merge pull request #8768 from cakephp/move-middleware
lorenzo d7e1ab3
Merge pull request #8767 from cakephp/asset-middleware
lorenzo 9f31c70
Merge branch 'master' into 3.next
markstory 18c3009
Add the LocaleSelectorMiddleware.
markstory 1f50eec
Fix grammar and use an early return.
markstory a537e9c
Start deprecating duplicate methods and adding PSR7 traits.
markstory 92081fa
Make header(), version() and method() play nice with PSR7
markstory 2e97ed6
Make url() interoperable with PSR7
markstory 76882b4
Fix wording.
markstory 11e6529
Make body() interoperable with PSR7 methods.
markstory 2e52015
Move body serialization into the Request.
markstory a495cb0
Get client tests passing.
markstory 592daec
Update Oauth adapter to parse encoded body data.
markstory 1bf62e0
Define the protocol property on the response.
markstory 66b59c2
Fix PHPCS errors.
markstory 334c40d
Fix parameter types in client\request.
markstory 60a01c8
allowEmpty and notEmpty to take field as list
Graziel 4178a46
some cs
Graziel fd64ba4
docBlock update
Graziel 664201b
Merge pull request #8776 from cakephp/locale-filter
markstory 9c92270
revert auto formatting
Graziel 9e96ecc
doc block fix
Graziel 27f52f2
another batch of revese changes
Graziel 503a74f
Merge branch 'master' into 3.next
markstory 6769a6c
Merge branch '3.next' into allowEmpty_notEmpty_array
Graziel 76ec4e0
fix message
Graziel d9f362e
add messege test to allowEmpty when set as array
Graziel 6189452
Merge pull request #8787 from cakephp/psr7-client-request
markstory 86e64ba
Fix err() to highlight error as red similar to warn() which is yellow.
dereuromark 4491622
Fix up tests.
dereuromark b7114a0
Fix up tests.
dereuromark 456c6fc
Throw exception if marshaller encounter missing/invalid associations …
Antoniossss 27c3a0d
Merge pull request #8811 from cakephp/fix-err-console
markstory 7727e20
Code refactoring due to comments @ https://github.com/cakephp/cakephp…
Antoniossss 3943052
Merge branch 'master' into 3.next
markstory 010f727
Remove duplicate code.
markstory 3f58c7d
Start making Http\Client\Response PSR7 compatible.
markstory aa90dce
Add getEncoding()
markstory fec9e58
Add new psr7-like methods for reading cookie data.
markstory 62a3a29
Refactor to use new methods.
markstory e3ce83f
Use PSR7 interface methods in doc blocks.
markstory 609224e
Fix PHPCS errors.
markstory 602704f
Fail with a slightly more helpful error messages.
markstory 17fb598
Previously added assertion was wrong...
markstory fc6cddc
Merge pull request #8822 from cakephp/psr7-client-response
lorenzo ae3d4a9
Fix PHPCS build.
markstory c03a217
Give Http\Client\Request a more useful constructor.
markstory 38d3cc5
Start using PSR7 interfaces more internally.
markstory 01f016a
Use PSR7 interfaces internally in auth plugins.
markstory e869e26
Merge pull request #8824 from Antoniossss/issue-8808
markstory e47c09b
Fix formatting and spacing.
markstory a219020
Fix PHPCS errors.
markstory 43e8926
Merge pull request #8800 from Graziel/allowEmpty_notEmpty_array
markstory 5a4a786
Formatting and doc block improvements.
markstory 253e0b6
Merge pull request #8837 from cakephp/psr7-client-internals
lorenzo 3027fc1
Add a branch alias for 3.next to installation easier.
markstory 1b40a06
Merge pull request #8868 from cakephp/3.3-branch-alias
markstory 208a355
Merge branch 'master' into 3.next
markstory e97a125
Merge branch '3.next' of github.com:cakephp/cakephp into 3.next
markstory 4ce2da2
add caches shell
a71cc74
Merge branch 'master' into 3.next
markstory 86e24ef
Fix failing tests in IsUnique rule.
markstory 05fa655
Use Query methods instead of digging into internals.
markstory c6a93d9
Fix issue with identifier quoting.
markstory d1a0ff1
Fix more failures around identifier quoting.
markstory 08bb082
Remove branch aliases.
markstory 6d8d7a7
rename CachesShell to CacheShell
087c614
Add warnings if cache engine is ApcEngine or WincacheEngine
602e0f9
fix typo in description
a60e844
convert FQCNs to use statements
933f814
Merge pull request #8900 from chris48s/7368-cache-shell
markstory 57e7877
Fix typo in documentation.
markstory b5e77bf
Merge remote-tracking branch 'origin/master' into 3.next
lorenzo cb65936
Using same trick as fbefore in the hope on pleasing travis' gods
lorenzo 9b32402
No more code coverage, it's got problems
lorenzo 14f9199
Remove $options argument from ContextInterface::val() to maintain BC.
ADmad 2cb3803
Making test more resilient for SQL Server
lorenzo 6aa63ba
Removing unused line in travis.yaml
lorenzo 2c7fa4a
Seems like SQL Server is missing the ids for a fixture without autoin…
lorenzo f7251c2
Another try at fixing SQL Server
lorenzo 12936a4
Another try at fixing SQL Server
lorenzo 50f90ba
Pretty please?
lorenzo 665254c
One last try for the day
lorenzo ec65adc
Skipping a test temporarilly
lorenzo 5b5a383
Fixed dumb mistake
lorenzo f9e013e
Ensure the app is always last in the middleware stack.
markstory d13a550
Save a few function calls.
markstory e02b884
Make allowMultipleNulls a constructor argument.
markstory a65a4f5
Merge pull request #8904 from cakephp/fix-travis-all-the-way
lorenzo 3b8e5a0
Fix PHPCS / docs errors.
markstory 33bbf84
Raise an exception in insertBefore()
markstory 2b3b365
Merge pull request #8735 from cakephp/3.3-context-schema-default
markstory c849f80
Fix typo.
markstory be0dcc0
Merge pull request #8920 from cakephp/insert-before-exception
lorenzo d7c52d5
Merge pull request #8913 from cakephp/app-last
markstory 051560c
Merge branch 'master' into 3.next
markstory 82393d1
Merge pull request #8914 from cakephp/is-unique-options
markstory 6c0844f
Merge branch 'master' into 3.next
markstory 138f50f
Merge branch 'master' into 3.next
ADmad 9f0820d
Start sketching out the PSR7 IntegrationTest work.
markstory 0ef9d47
Rough out Middleware Dispatcher
markstory 43f8ed3
Make IntegrationTestCase::_buildRequest return an array.
markstory d086c6f
Small fixes.
dereuromark d43864b
Remove unused import.
markstory 618457e
Fix PHPUnit getMock warnings in 3.next.
markstory 9114949
Add Collection::transpose method (#8957)
dilab 2f4f433
Clean up Collection::transpose().
markstory fc6cfe8
Update PSR7 integration tests based on feedback.
markstory 632a525
Merge pull request #9000 from cakephp/phpunit-warnings
antograssiot f7fb9b7
Make stream error handling method public to handle errors in custom s…
Marlinc da39cd3
Allow PSR7 requests to store the session as an attribute.
markstory 61ef064
Add session support for PSR7 requests.
markstory 3af2377
Remove TODOs
markstory 93a8836
Allow request bodies to be transformed.
markstory a8567c5
Add integration tests for PSR7 + request bodies.
markstory 745aefc
Don't call getSize()
markstory 3eb2982
Merge pull request #8992 from cakephp/psr7-integration-test
lorenzo a3ef37d
Merge branch 'master' into 3.next
markstory bd4dc9a
Merge branch '3.next' of github.com:cakephp/cakephp into 3.next
markstory b2f1c72
Convert cookies from CakePHP responses to PSR7 ones.
markstory 6a72463
Add cookie parsing to convert from psr7 to cakephp.
markstory cadeb64
Add integration test for cookies + psr7
markstory 38c903b
Merge pull request #9019 from cakephp/integration-test-cases
lorenzo db36ed0
Basic Idea
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private method name "Connection::isolationLevel" in CakePHP core is discouraged
Missing function doc comment