Sorry, wrong branch :( #9024
Closed
Sorry, wrong branch :( #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
values convertible to other expressions
Version 3.8 is the minimum sqlite version fro php 5.5
Improving the function translator for SUBSTR in SQL Server Appending a LEN function instead of using RIGHT Trying to fix funciton translaotr trying to fix sql server tests one last try Skipping tests in Sql Server, as I don't have access to a windows machine where I cn debug Doing the previous commit right
Missing templates are a signal that a developer has made a mistake. We should help them find this error and an exception is the simplest way to signal an error to the developer. Refs cakephp#8554
This reverts commit 64ec05c. I accidentally committed this to the wrong branch. And we have force push disabled.
Missing templates are a signal that a developer has made a mistake. We should help them find this error and an exception is the simplest way to signal an error to the developer. Refs cakephp#8554
…ecode Add support for returning decoded subjects
…guments Add argument support for detectors
Missing templates should raise exceptions.
Support for expression converting types
This is the first of many features needed to build out the PSR7 support in CakePHP. The MiddlewareStack provides an interface for managing a stack of middleware objects that will be applied to incoming request/response objects. I've not included support for conditionally applied or path specific middleware. I see this as an improvement to be done once the basics are in place.
* Add transpose method to collection class * Revert composer.json file * Remove TransposeIterator subclass * Remove double lines * Use standard CakePHP file header * Handle uneven length array * Remove debug line * Remove some space to please lint * Throw LogicException if arrays do not share the same length * Use a local variable to keep array value * Use current() instead of first() * Use toList() instead of toArray() to preserve all values
Fix PHPUnit getMock warnings in 3.next.
By allowing the session to exist on the PSR7 request, it will be easier to implement integration test case flows and more importantly let people access the session from their psr7 requests.
The base and webroot attributes are handled by the RequestTransformer. I'm not convinced that php://input needs to be handled as the legacy dispatcher doesn't do a great job of it either.
This is useful for API based applications.
getSize() can be expensive, instead read the stream and conditionally assign the input with the stream contents.
PSR7 IntegrationTestCase part 1
I missed this before, but we'll need to handle cookie data conversion. I really wanted to use one of the predefined date constants, but none of them seemed to match RFC6265.
Re-purpose the cookie parsing code that lives in the 2.x HttpSocket here. I figured that was a good place to draw an implementation from as its fairly battle tested and works well.
Fix Cookie support for PSR7 response transformer
| @@ -737,4 +770,9 @@ public function __debugInfo() | |||
| 'logger' => $this->_logger | |||
| ]; | |||
| } | |||
|
|
|||
| private function isolationLevel($isolationLevel = null) | |||
There was a problem hiding this comment.
Private method name "Connection::isolationLevel" in CakePHP core is discouraged
Missing function doc comment
|
My bad, wrong branch 😨 |
half2me
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry wrong branch :(