ISO 8601: Missing colon in timezone

[dereuromark]

Shouldn't the toIso8601String() method have an colon between the hours and minutes in the timezone part?
1975-12-25T14:15:16-0500 becomes 1975-12-25T14:15:16-05:00

Spec: http://www.w3.org/TR/NOTE-datetime

Refs briannesbitt/Carbon#451

[markstory]

We're using the PHP constant The chances of that being wrong seem pretty low.

[dereuromark]

There is a note below that linked documentation:

Note: This format is not compatible with ISO-8601, but is left this way for backward compatibility reasons. Use DateTime::ATOM or DATE_ATOM for compatibility with ISO-8601 instead.

What an irony for a constant called DateTime::ISO8601

[dereuromark]

So either we fix it ourselves (add the colon) or should promote using the outlined formats.

[ADmad]

This format is not compatible with ISO-8601, but is left this way for backward compatibility reasons.

Heh, so someone made a mistake initially and instead of fixing it they decided to stick with it. PHP is full of funnies.

[markstory]

Bloody Hell. Well, we can use ATOM instead of ISO8601

[markstory]

Pull request up.