Start deprecations for 2.next #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are currently failing, but I was conflicted on how to proceed. * Should we add a method like `deprecated(Closure)` to chronos' test library? * Should we copy the `deprecationWarning` helper from Cake to chronos as well?
othercorey
reviewed
Nov 8, 2022
src/Traits/ModifierTrait.php
Outdated
| @@ -296,6 +296,8 @@ public function addYears(int $value): ChronosInterface | |||
| */ | |||
| public function addYear(int $value = 1): ChronosInterface | |||
| { | |||
| trigger_error('2.4 - addYear() is deprecated. Use addYears() instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Let's us a similar format to cake core. Since 2.4.0, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are currently failing, but I was conflicted on how to proceed.
deprecated(Closure)to chronos' test library?deprecationWarninghelper from Cake to chronos as well?