Cleanup LdapSource #114
Merged
Cleanup LdapSource #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ctgraham
commented
Feb 25, 2015
ctgraham
commented
- Add missing method documentation
- Remove invalid use of error control operators on ldap_* calls
- initialize missing variables: $this->_queriesCnt and $this->_queriesLog
- remove unused variables: $this->_queriesLogMax from logQuery() and $i from _mergeAssociation()
- correct variable naming typos: $hasFailover/$hasFailOver and $this->SchemaFilter/$schemaFilter
- add 'fields' parameter when generating associations
- correct PHPDoc use of integer and boolean to int and bool.
- correct PHPDoc use of initial capitalization in params and returns.
- correct inconsistent use of $this->results vs. $this->_result.
|
Nice. Especially the removals of 👍 |
| @@ -287,11 +301,11 @@ public function close() { | |||
|
|
|||
| /** | |||
| * disconnect close connection and release any remaining results in the buffer | |||
| * | |||
| * @return boolean the connection status | |||
|
I think this is good to go. Could you squash the commits, they are all about cleaning up. |
ctgraham
force-pushed
the
cleanup-ldap-datasource
branch
from
1788786
to
1a59415
Compare
…rror control operators on ldap_* calls; initialize missing variables; remove unused variables; correct variable naming typos; add fields parameter when generating associations; correct documentation use of initial capitalization in parameters/returns; correct documentation use of int and bool.
ctgraham
force-pushed
the
cleanup-ldap-datasource
branch
from
1a59415
to
1ea5bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.