Don't proxy invalid configuration

If a cache configuration doesn't have a `className` we shouldn't proxy it as it is malformed. Fixes #682
cakephp · May 31, 2019 · 07e56fa · 07e56fa
1 parent 979c23e
commit 07e56fa
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/Panel/CachePanel.php b/src/Panel/CachePanel.php
@@ -41,12 +41,14 @@ public function initialize()
             $config = Cache::getConfig($name);
             if (isset($config['className']) && $config['className'] instanceof DebugEngine) {
                 $instance = $config['className'];
-            } else {
+            } elseif (isset($config['className'])) {
                 Cache::drop($name);
                 $instance = new DebugEngine($config);
                 Cache::setConfig($name, $instance);
             }
-            $this->_instances[$name] = $instance;
+            if (isset($instance)) {
+                $this->_instances[$name] = $instance;
+            }
         }
     }
 

diff --git a/tests/TestCase/Panel/CachePanelTest.php b/tests/TestCase/Panel/CachePanelTest.php
@@ -48,6 +48,7 @@ public function tearDown()
     {
         parent::tearDown();
         Cache::drop('debug_kit_test');
+        Cache::drop('incomplete');
     }
 
     /**
@@ -64,6 +65,21 @@ public function testInitialize()
         $this->assertArrayHasKey('_cake_model_', $result['metrics']);
     }
 
+    /**
+     * test initialize incomplete data
+     *
+     * @return void
+     */
+    public function testInitializeNoProxyIncompleteConfig()
+    {
+        $data = ['duration' => '+2 seconds'];
+        Cache::setConfig('incomplete', $data);
+        $this->panel->initialize();
+
+        $config = Cache::getConfig('incomplete');
+        $this->assertSame($data, $config);
+    }
+
     /**
      * test initialize incomplete data
      *