Merge request & session and environment & include panels #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a separate for just session data seems redundant when session data is always accessed through the request.
my local version was out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that there are too many panels in debugkit and that we could benefit from collapsing some panels. I'm also considering merging
DeprecationsandLogpanel together as deprecation warnings are a form of logs.I've left the panels in the source as userland configuration could have
Session => trueand I don't want to break that. One open question I have is whether or notEnvironmentpanel should have configuration to turn off saving include path data. Skipping include path data can help keep debugkit data size down.