Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x: Type::build() removal missing #7561

Closed
dereuromark opened this issue Dec 29, 2022 · 5 comments
Closed

5.x: Type::build() removal missing #7561

dereuromark opened this issue Dec 29, 2022 · 5 comments

Comments

@dereuromark
Copy link
Member

dereuromark commented Dec 29, 2022

Seems to be missing from migration/upgrade guides

bootstrap

Type::build('time');
Type::build('date');
Type::build('datetime');
Type::build('timestamp');

as well as e.g.

Type::map('array', ArrayType::class);

inside Model/Behavior code

@dereuromark dereuromark changed the title 5.x: Type::map() removal missing 5.x: Type::build() removal missing Dec 29, 2022
@markstory markstory added this to the 5.x milestone Dec 29, 2022
@markstory
Copy link
Member

markstory commented Dec 29, 2022

This method is also missing a deprecation in 4.next. I can take care of both changes.

The methods are still present in TypeFactory::build. We are missing a runtime deprecation in 4.next though.

@dereuromark
Copy link
Member Author

dereuromark commented Dec 29, 2022

And docs in migration etc, I was looking for build() and Type:: etc, and didnt find anything.
Same for Type::buildAll() which is now TypeFactory::buildAll()

Also _initializeSchema() removal doesnt seem to be covered in upgrade or migration guide

@markstory
Copy link
Member

Looks like these methods were deprecated in cakephp/cakephp@598bc5ed038 and we forgot to update the docs and add runtime deprecations for them.

markstory added a commit to cakephp/cakephp that referenced this issue Dec 29, 2022
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/console that referenced this issue Apr 8, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/core that referenced this issue Apr 8, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/database that referenced this issue Apr 8, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/datasource that referenced this issue Apr 8, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/http that referenced this issue Apr 8, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
@github-actions
Copy link

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale label May 27, 2023
@markstory
Copy link
Member

Closing as runtime deprecations have been added to 4.5

markstory added a commit to cakephp/database that referenced this issue Sep 29, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
markstory added a commit to cakephp/datasource that referenced this issue Sep 30, 2023
We added many class rename deprecations during 4.x but didn't include
runtime deprecations for them. Adding runtime deprecations in 4.5 will
encourage developers to update their code before the breaking change in
5.0

Refs cakephp/docs#7561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants