Follow up to #137 #142
Merged
Follow up to #137 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options mode should use a InputOption constant. Flags (bool values) use a `InputOption::VALUE_NONE` mode and options which are expecting a value should use `InputOption;;VALUE_REQUIRED`
|
Hold on, I found a weird bug. |
…mmand when a snapshot is baked
HavokInspiration
changed the title
|
Ok it was not that weird of a bug. I changed the title and description of the PR since it addresses multiple things now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two goals :
It's a follow up to #137, I forgot a key point when adding options : they have to be added to the MigrationsShell class otherwise the shell call can't execute.
I also updated the dispatched command that was issued after a snapshot was baked so it doesn't mark all migrations as migrated.
Options mode should use a
InputOptionconstant. Flags (bool values) use aInputOption::VALUE_NONEmode and options which are expecting a value should useInputOption;;VALUE_REQUIREDRefs http://symfony.com/doc/current/components/console/introduction.html#using-command-options