Mostly PSR-2 compliant #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one fail related to extending a CakePHP core method that is not yet PSR-2 compliant as it begins with an underscore
|
The whitespace diff looks good. Did you use phpcs-fixer for this? Also the underscore methods can be suppressed by turning off warnings and only looking at errors if I remember correctly. |
|
I manually fixed the files since there were so few. |
|
@josegonzalez could you indent the doc blocks correctly? |
|
Is that incorrect? I ran phpcs against it with psr2 standard... |
|
@josegonzalez the standard actually excludes doc blocks - but it's an artefact of our existing code standard that I don't think anyone else follows. |
|
K, I'll indent. |
|
There are code sniffer rules to do that automatically, e.g. mine. If you run it isolated, it should work. |
CakePHP core code generally does not have comments inside of methods - this indicates that the method should be refactored - and these methods certainly do not need comments.
|
I indented everything, waiting on tests to pass and then I'll merge. |
The underscored version can be removed when the CakePHP core becomes PSR-2 compliant
This file uses both a require and a define, which is a no-no for phpcs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one fail related to extending a CakePHP core method that is not yet PSR-2 compliant as it begins with an underscore.
Will merge after #24