Patch constraintnames #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you 🎉 |
ndm2
added a commit
to ndm2/migrations
that referenced
this pull request
Aug 14, 2023
Partially reverts cakephp#615, as it didn't account for other usages of the `add-foreign-keys` element, where `constraints` is not indexed by table name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
When baking migration_diff/snapshot, the names defined in the constraints are used in the migration file now.
Sorry, but this is my first pull request ever. Please tell me if I'm doing anything wrong, so I can try to do it better ;)