Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Make diff tests run again #623

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

ndm2
Copy link
Contributor

@ndm2 ndm2 commented Aug 14, 2023

Partially reverts #615, as it didn't account for other usages of the add-foreign-keys element, where constraints is not indexed by table name.

Partially reverts #615, as it didn't account for other usages of the
`add-foreign-keys` element, where `constraints` is not indexed by
table name.
Copy link
Contributor

@LordSimal LordSimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ndm2 ndm2 merged commit db63443 into 4.x Aug 18, 2023
10 checks passed
@ndm2 ndm2 deleted the 4.x-make-diff-tests-running-again branch August 18, 2023 21:45
@LordSimal LordSimal added this to the 4.x (CakePHP 5) milestone Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants