Critical bug with composer.json #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal Schneider in slack pointed an issue unable to install cakephp/migrations https://cakesf.slack.com/archives/C053DPNGT/p1695333660872039 As you all know phinx had a release tag of 2.0.0 which was removed as mentioned in https://github.com/cakephp/phinx/releases/tag/0.15.0 So this is breaking currently and should be fixed ASAP.
harikt
commented
Sep 22, 2023
| @@ -22,7 +22,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": ">=8.1", | |||
| "robmorgan/phinx": "^2.0", | |||
| "robmorgan/phinx": "^0.15", | |||
There was a problem hiding this comment.
Note : I am keeping this as ^0.15 and not 1.x-dev because when migrations is released it cannot install the correact version from the tag. We may want to bump the version according to phinx releases.
|
Will be released soon as bugfix |
|
That seems not fixing the issue. I noticed the units are broken. Checking on local. |
Merged
|
@dereuromark fixed via #641 |
|
Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pascal Schneider in slack pointed an issue unable to install cakephp/migrations
https://cakesf.slack.com/archives/C053DPNGT/p1695333660872039
As you all know phinx had a release tag of 2.0.0 which was removed as mentioned in https://github.com/cakephp/phinx/releases/tag/0.15.0
So this is breaking currently and should be fixed ASAP.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
Always follow the contribution guidelines when submitting a pull request. In particular, make sure existing tests still pass, and add tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.