Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the input interface #641

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix the input interface #641

merged 1 commit into from
Sep 22, 2023

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Sep 22, 2023

I noticed the unit tests on the #640 was failing. This was due to some changes with the type declaration.

@harikt harikt mentioned this pull request Sep 22, 2023
Merged
@dereuromark dereuromark merged commit 56a76dd into cakephp:4.x Sep 22, 2023
6 of 10 checks passed
@harikt
Copy link
Contributor Author

harikt commented Sep 22, 2023

The sqlite tests seems failing for some other reason.

                 [\n
-                    'name' => 'category_id_fk',\n
+                    'name' => 'category_id_0_fk',\n
                 ]\n

@harikt harikt deleted the patch-phinx branch September 22, 2023 01:38
@dereuromark
Copy link
Member

I think they already failed before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harikt @dereuromark