Add dump option #1127
Merged
Add dump option #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo
reviewed
Jul 23, 2017
| @@ -47,6 +47,7 @@ protected function configure() | |||
| ->setDescription('Migrate the database') | |||
| ->addOption('--target', '-t', InputOption::VALUE_REQUIRED, 'The version number to migrate to') | |||
| ->addOption('--date', '-d', InputOption::VALUE_REQUIRED, 'The date to migrate to') | |||
| ->addOption('--dump', '-x', InputOption::VALUE_NONE, 'Dump query to standard output instead of executing it') | |||
There was a problem hiding this comment.
Do you mind renaming this to dry-run or attempt?
|
I'm not sure this solution is actually going to work for all cases, but it is a good start. |
|
@lorenzo the name |
|
Thanks @kerneldemon! Would you mind adding a brief explanation of this new flag to the docs? |
|
@lorenzo I contemplated adding a separate section that would describe the option, but since the option can only be used by two commands, I thought it would be better to just have the same text for migrate and rollback command section. |
|
@kerneldemon duplicating the test sounds good |
|
@lorenzo Moved the text slightly. Is anything else missing? |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'd like a way to dump plain sql using the
phinx migrateandphinx rollbackcommands, so I added a--dumpoption.This is useful for those who would like to read raw queries before running them in production, there's a discussion about this here.