Implement a --dry-run option #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Phinx | ||
| * | ||
| * (The MIT license) | ||
| * Copyright (c) 2015 Rob Morgan |
There was a problem hiding this comment.
Assigning the copyright, or should it be you?
There was a problem hiding this comment.
Far as I can tell, this is what's done in the files you've contributed, so I just followed suit.
|
Alright, let's keep this approach for now. |
|
@shadowhand Should we just point wheniwork-db to this fork, or should we try to submit this upstream? |
|
@elazar for now let's point at this fork. I'd like to try a cleaner injection before we submit upstream. |
|
This is an important feature. +1 |
ghost
mentioned this pull request
|
Potentially relevant: looks like there's an open PR for this upstream, cakephp#746. The approach seems to be similar to the way I did it. |
|
This was implemented in cakephp#1127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. This PR is intended only for internal peer review prior to submitting the changes upstream, assuming we do eventually decide to do so.
A few things I don't like about the current implementation, but have yet to find a way to work around:
OutputInterfaceinstance in various areas. The core has its own output surrounding each migration that's difficult to reliably differentiate from dry run output. Because the core output would make copying and pasting the output of a dry run a lot more troublesome, the current approach simply changes the output verbosity level to squelch the core output.ReadOnlyProxyStatementtoOutputInterface. The alternative is to duplicate the code to manipulate output verbosity levels inDryRunAdapter, which would require overriding most if not all of the methods ofAdapterWrapperto be able to call that code.ReadOnlyProxyConnectiontoOutputInterface. This is the best way I've found to make this interoperable with the rest of the core while still supporting the output of generated SQL statements.Refs cakephp#567