Make removeIndex work with one column as a string #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo
reviewed
Sep 13, 2018
src/Phinx/Db/Action/DropIndex.php
Outdated
| * @return DropIndex | ||
| */ | ||
| public static function build(Table $table, array $columns = []) | ||
| public static function build(Table $table, $columns = []) |
There was a problem hiding this comment.
Can you leave this as-is and make the casting in the calling sites instead?
lorenzo
reviewed
Sep 13, 2018
| * @return \Phinx\Db\Table | ||
| */ | ||
| public function removeIndex(array $columns) | ||
| public function removeIndex($columns) |
There was a problem hiding this comment.
This is ok, just need to cast to array when building the action
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.