Add XML and IOD data type #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garas
reviewed
Oct 31, 2018
garas
reviewed
Oct 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
============================================
+ Coverage 74.51% 74.51% +<.01%
- Complexity 1971 1979 +8
============================================
Files 54 54
Lines 5831 5851 +20
============================================
+ Hits 4345 4360 +15
- Misses 1486 1491 +5
Continue to review full report at Codecov.
|
lorenzo
reviewed
Nov 1, 2018
| @@ -848,6 +854,7 @@ public function getSqlType($type, $limit = null) | |||
| return ['name' => 'varchar', 'limit' => $limit ?: 255]; | |||
| case static::PHINX_TYPE_CHAR: | |||
| return ['name' => 'char', 'limit' => $limit ?: 255]; | |||
| case static::PHINX_TYPE_XML: | |||
dereuromark
reviewed
Jan 21, 2019
| 'inet', | ||
| 'macaddr', | ||
| 'interval', | ||
| ]); |
|
Any update on this? |
|
ping @LevZaplatin |
|
Would love to see this merged. |
|
Can we resolve the conflicts or open a new PR? Then we can continue |
|
@GhaziTriki Are you able to help out here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.