-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XML and IOD data type #1458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
============================================
+ Coverage 74.51% 74.51% +<.01%
- Complexity 1971 1979 +8
============================================
Files 54 54
Lines 5831 5851 +20
============================================
+ Hits 4345 4360 +15
- Misses 1486 1491 +5
Continue to review full report at Codecov.
|
@@ -848,6 +854,7 @@ public function getSqlType($type, $limit = null) | |||
return ['name' => 'varchar', 'limit' => $limit ?: 255]; | |||
case static::PHINX_TYPE_CHAR: | |||
return ['name' => 'char', 'limit' => $limit ?: 255]; | |||
case static::PHINX_TYPE_XML: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about oid columns?
'inet', | ||
'macaddr', | ||
'interval', | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation off
Any update on this? |
ping @LevZaplatin |
Would love to see this merged. |
Can we resolve the conflicts or open a new PR? Then we can continue |
@GhaziTriki Are you able to help out here? |
No description provided.