Add existing comment to column object for mysql #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Looks good to me |
|
Looks ok to me. Do we have a test harness for this information we can add comments to? |
MasterOdin
requested changes
Feb 9, 2023
There was a problem hiding this comment.
Please add a row for testing the comment field to this test:
phinx/tests/Phinx/Db/Adapter/MysqlAdapterTest.php
Line 1311 in cea47f6
You are right we don't set the comment for any of the adapters I think. Would you want to take a stab at adding that in for them?
Sorry, have not much idea about the other adapters |
alex-jonas
requested review from
MasterOdin
and removed request for
othercorey
Sinepel
approved these changes
Mar 1, 2023
dereuromark
approved these changes
Mar 1, 2023
MasterOdin
approved these changes
Mar 1, 2023
MasterOdin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Table::getColumn($name)method you would expect that afterwards the comment is available in the Column object.At least in Mysql this is not the case... therefore my change.