Initial implementation of a breakpoint for migration rollback. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
51904d8
to
8b5dd71
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
2 times, most recently
from
6907de0
to
137a177
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
137a177
to
cbbe386
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
3 times, most recently
from
eb52607
to
5f1a6a7
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
c672583
to
16f536b
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
16f536b
to
5374f27
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
5374f27
to
6c54782
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
6c54782
to
cca7a70
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
b8badb9
to
4b5fdee
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
4b5fdee
to
983a43c
Compare
|
waiting to see if theres further support from the community |
rquadling
force-pushed
the
feature/BreakpointSupport
branch
2 times, most recently
from
41e74fa
to
3d8af56
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
3d8af56
to
a896c73
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
a896c73
to
d544759
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
d544759
to
be8090b
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
be8090b
to
2340a44
Compare
|
This is a really good feature and I would love to see if incorporated into phinx! It means you can have a "safety net" so you don't accidentally roll back all your database changes. It also means that when you start a new task, you can put a breakpoint in on the "current" change, and it's really easy to roll back to that point while you're working on that task. |
This was referenced Nov 17, 2015
Closed
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
b5474d5
to
4986783
Compare
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
349332d
to
2966e04
Compare
Old domain of box project is squatted!
Add support for type YEAR
Change box project lint to actual github page.
MySQL adapter add support for type YEAR - Issues cakephp#551
… a better placement.
Updated tests to support statuses requirement of needing the full row to display the breakpoint.
…list of version numbers, the other returns the full row (along with the breakpoint flag). Updated the testRollbacksByDate test to mock the getFullVersions() call appropriately. Updated the testMigrationsByDate test to verify that getFullVersions() is not called as the full record is not needed as part of the migration run.
rquadling
force-pushed
the
feature/BreakpointSupport
branch
from
2966e04
to
7c08008
Compare
|
Thank you for contributing! The branch you made this PR against is no longer accepting patches. This probably happened because we didn't merge your changes fast enough. 😭 Please create a new PR against the current default branch if you want to see these changes merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #494 for the issue.