Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 8. #35

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Run tests on PHP 8. #35

merged 1 commit into from
Oct 24, 2020

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Oct 23, 2020

No description provided.

@ADmad ADmad added this to the 1.0.0 milestone Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
+ Complexity       76       74    -2     
=========================================
  Files             9        9           
  Lines           222      222           
=========================================
  Hits            200      200           
  Misses           22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f623a...9ab06e4. Read the comment docs.

@ADmad ADmad force-pushed the php-8 branch 3 times, most recently from 295995d to e3c31a3 Compare October 23, 2020 15:47
@ADmad
Copy link
Member Author

ADmad commented Oct 23, 2020

Someone need to send a PR to php-enqueue/simple-client for proper PHP 8 compatibility so that --ignore-platform-deps is not required when installing on PHP 8.

@markstory markstory merged commit c566064 into master Oct 24, 2020
@markstory markstory deleted the php-8 branch October 24, 2020 02:07
@markstory
Copy link
Member

@ADmad I can open an issue on the enqueue-dev repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ADmad @markstory