Added deprecation warning for cell and element tags

cakephp · Apr 10, 2020 · 86fe1d7 · 86fe1d7
1 parent c65e158
commit 86fe1d7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/Twig/TokenParser/CellParser.php b/src/Twig/TokenParser/CellParser.php
@@ -38,6 +38,14 @@ class CellParser extends IncludeTokenParser
      */
     public function parse(Token $token): Node
     {
+        static $warned = false;
+        if (!$warned) {
+            $warned = true;
+            deprecationWarning(
+                '`cell` and `element` tags are deprecated. Use `cell()` and `element()` functions instead.'
+            );
+        }
+
         $stream = $this->parser->getStream();
 
         $variable = null;

diff --git a/src/Twig/TokenParser/ElementParser.php b/src/Twig/TokenParser/ElementParser.php
@@ -38,6 +38,14 @@ class ElementParser extends IncludeTokenParser
      */
     public function parse(Token $token): Node
     {
+        static $warned = false;
+        if (!$warned) {
+            $warned = true;
+            deprecationWarning(
+                '`cell` and `element` tags are deprecated. Use `cell()` and `element()` functions instead.'
+            );
+        }
+
         $stream = $this->parser->getStream();
         $name = $this->parser->getExpressionParser()->parseExpression();
 

diff --git a/tests/TestCase/View/TwigViewTest.php b/tests/TestCase/View/TwigViewTest.php
@@ -127,8 +127,10 @@ public function testCellsShareTwig()
      */
     public function testDeprecatedTags()
     {
-        $output = $this->view->render('deprecated_tags', false);
-        $this->assertSame("<b>10</b>\nblog_entry", $output);
+        $this->deprecated(function () {
+            $output = $this->view->render('deprecated_tags', false);
+            $this->assertSame("<b>10</b>\nblog_entry", $output);
+        });
     }
 
     /**