-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cell() and element() twig functions #29
Conversation
I wonder if it is safe to cache the TwigEnvironment instance in a static variable so Cell's don't create new ones for every render. |
293b9c6
to
51fea2a
Compare
I think it should be. |
fd2ad84
to
3074f80
Compare
Twig Environment instance is now cached. If we want to test creating new Environment instances later, we will need to add a way to clear it. |
6e6a816
to
dab73e8
Compare
dab73e8
to
2870d65
Compare
The readme needs to be updated with new function usage examples. |
I was going to re-write it once we've finished our cleanup since we keep adding/changing new functions. Is that ok? |
I think |
I was thinking about adding a single deprecation notice to each and adding a unit test that verify deprecation warning for the element tag. I don't know if we want to spam warnings while people transition though. |
Yeah that doesn't sound too nice. I am leaning towards just documenting the deprecations. |
I added a unit test to cover the deprecated tags and all of the node code. |
#22