Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to EvalError #163

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Add context to EvalError #163

merged 6 commits into from
Mar 15, 2023

Conversation

jordemort
Copy link
Contributor

Closes #142

@jordemort jordemort merged commit eb813c0 into main Mar 15, 2023
@jordemort jordemort deleted the evalerror-context branch March 15, 2023 15:39
@colindean
Copy link
Contributor

Awesome!

@jordemort
Copy link
Contributor Author

@colindean This was technically an API break because it changes the constructor of EvalError but I'm not sure it's worth 2.0 on its own

I was going to try and knock out these over the next couple weeks before I tag a new major version:

If you want this change in a published release sooner LMK and I'll tag a point release for you; I think it's OK to bend the semver rules since I doubt anyone is using the EvalError constructor directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation errors missing context while syntax errors have them
2 participants