-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue77 #78
Issue77 #78
Conversation
Hey guys, If you have any suggestions, please drop a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, again, for the delay. I haven't had a chance to run the sample app yet, but these changes look great to me. I agree with the checkboxes you've set out in your PR description. We also love FactoryBoy, so yes, feel free to change tests to use that if it makes things easier/clearer.
Thanks again for taking on this work! 💯
setup.py
Outdated
'Topic :: Software Development :: Libraries :: Python Modules', | ||
'Development Status :: 5 - Production/Stable', | ||
'Operating System :: OS Independent', | ||
], | ||
long_description=open('README.rst').read(), | ||
install_requires=[ | ||
"django-mptt>=0.8.6,<1.0", | ||
"django-mptt>=0.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to add ,<1.0
here, in case a future major version has backwards incompatible changes.
treenav/tests/test_templatetags.py
Outdated
@@ -10,9 +10,17 @@ | |||
register, | |||
show_treenav, | |||
single_level_menu, | |||
CaktNode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like flake8 says this is an unused import, so can be removed.
I've corrected the code that you've pointed out. I'm not sure why coveralls doesn't work. |
Thank you @itsdkey! I also am not sure why coveralls is complaining, but this looks great to me! |
Sure, no problem 👍 |
So what is done here:
a) python3.6 - python3.8
b) django2.2 - django3.0 (because these versions are currently supported)
c) travis (I used the existing config, only changed the python version to 3.8)
d) docs (I used the existing config, only changed the python version to 3.8)
What still needs to be done:
Things to consider: