fix feature tests #1263
Merged
fix feature tests #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
afeld
force-pushed
the
fix/feature-tests
branch
6 times, most recently
from
95a73f7
to
b377b69
Compare
afeld
commented
Feb 14, 2023
| @@ -51,6 +51,8 @@ CYPRESS_baseUrl=http://localhost:8000 npm run cypress:open | |||
|
|
|||
| See `tests/cypress/package.json` for more cypress scripts. | |||
|
|
|||
| As of Cypress 12.5.1 with Firefox 109, there is a CSRF issue that prevents the tests from passing; unclear if this is a bug in Cypress or what. Use one of the other browser options. | |||
afeld
commented
Feb 14, 2023
| @@ -201,14 +202,19 @@ def load_sample_data(app, *args, **kwargs): | |||
|
|
|||
| TransitAgency = app.get_model("core", "TransitAgency") | |||
|
|
|||
| # load the sample data from a JSON file so that it can be accessed by Cypress as well | |||
There was a problem hiding this comment.
See this note. Essentially going back to fixtures, just for the sake of the sample data. Doesn't change anything in Azure.
afeld
commented
Feb 14, 2023
afeld
commented
Feb 14, 2023
afeld
force-pushed
the
fix/feature-tests
branch
from
b377b69
to
96b16da
Compare
afeld
force-pushed
the
fix/feature-tests
branch
from
96b16da
to
4eba3f9
Compare
Matches the local dev setup more closely, and simplifies the CI setup.
|
Progress! Three Cypress tests are passing 🎉 |
afeld
commented
Feb 15, 2023
| -p 5000:5000 \ | ||
| ghcr.io/cal-itp/eligibility-server:dev | ||
| touch .env | ||
| docker compose up --detach client server |
There was a problem hiding this comment.
Was able to simplify, and more closely match our local setup.
This reverts commit 35f90a2.
Merged
thekaveman
approved these changes
Feb 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340.
Gets the feature tests working again, and sets them to run on every
pushin CI.