Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Sentry): handle cases where Git is available but we're not in a repository #1275

Merged
merged 1 commit into from Feb 15, 2023
Merged

fix(Sentry): handle cases where Git is available but we're not in a repository #1275

merged 1 commit into from Feb 15, 2023

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Feb 15, 2023

I guess I didn't test this case, where git is available but we're not in a repository, which is the case in App Service.

@afeld afeld requested a review from a team as a code owner February 15, 2023 03:39
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. labels Feb 15, 2023
@afeld afeld enabled auto-merge February 15, 2023 03:40
thekaveman
thekaveman approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some pytests for this?

@afeld afeld merged commit f2503e5 into dev Feb 15, 2023
@afeld afeld deleted the fix/sentry-no-repo branch February 15, 2023 17:09
@afeld
Copy link
Contributor Author

afeld commented Feb 15, 2023

Will think about how best to do that as a follow-up.

@afeld afeld mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees
No one assigned
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afeld @thekaveman