Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for Sentry revision code #1281

Merged
merged 2 commits into from Feb 16, 2023
Merged

add tests for Sentry revision code #1281

merged 2 commits into from Feb 16, 2023

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Feb 16, 2023

As requested in #1275 (review). Given that code calls out to the git executable and filesystem so much, a lot needs to be mocked, so not sure these tests add a lot of value 馃し Coverage:

image

Generated with

pytest --cov=benefits --cov-report=html tests/pytest/test_sentry.py
open htmlcov/index.html

@afeld afeld requested a review from a team as a code owner February 16, 2023 06:12
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. labels Feb 16, 2023
@afeld afeld enabled auto-merge February 16, 2023 21:47
@afeld afeld merged commit d1145ba into dev Feb 16, 2023
@afeld afeld deleted the chore/sentry-rev-tests branch February 16, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants