Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: delete now unneeded Azure file mount #1328

Merged
merged 1 commit into from Mar 23, 2023

Conversation

angela-tran
Copy link
Member

Part of #1244

This PR removes the file mount path from the App Service.

I checked over documentation, and it does not contain any mention of the blob container or file mount path anywhere.

@angela-tran angela-tran added this to the Refine secrets management milestone Mar 22, 2023
@angela-tran angela-tran requested a review from a team as a code owner March 22, 2023 20:58
@angela-tran angela-tran self-assigned this Mar 22, 2023
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Mar 22, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

Do we have any idea about this client_certificate_exclusion_paths entry that is marked for deletion in the plan?

image

@angela-tran
Copy link
Member Author

Do we have any idea about this client_certificate_exclusion_paths entry that is marked for deletion in the plan?

Hmm, yeah I am not sure where that is coming from. I think it might be ok since it's just going from an empty string to null.

@angela-tran angela-tran merged commit 426aae2 into dev Mar 23, 2023
9 checks passed
@angela-tran angela-tran deleted the refactor/delete-file-mount branch March 23, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants