-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document copy/translation/i18n/PO file process #1447
Conversation
@indexing I started the Markdown file. Please propose changes by making a GitHub comment on the line (or adding a suggestion commit https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-comments-to-a-pull-request, like I did here: https://github.com/cal-itp/benefits/pull/1447/files#r1239300498), and I can merge the suggestions in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are super helpful!
Can I suggest/request that we move them into a page in our /docs
folder so they show up in the https://docs.calitp.org/benefits site and are more easily accessible for everyone? Maybe under the Configuration section?
We can still use the README in /benefits/locale
to link to this online documentation (see an example of this pattern in the /terraform
directory)
benefits/locale/README.md
Outdated
- Syncing copy from [Benefits String Spreadsheet](https://docs.google.com/spreadsheets/d/13YZLv7wf8dAk_HnEP-KLEUurTggx8QOx9HovEW4_UjI/edit#gid=0) into Figma. | ||
- Ensuring the string is in the appropriate column (e.g. `Subtitle`, `ButtonLabel`) | ||
|
||
### Engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a reminder to run bin/makemessages.sh
: #1436 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #1571 is done, engineers should be editing copy directly in the app for English, then running bin/makemessages.sh
, then updating the corresponding Spanish in the PO file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current status
|
Lots of new stuff here: #1410 (comment) |
NIST is |
3407108
to
b3503f7
Compare
@indexing This page is ready for your review: https://github.com/cal-itp/benefits/pull/1447/files#diff-def4742fd8f91b94db56a5c970797fe316f277c2d0e2604c0e3ac1bd2c2edb8d |
@thekaveman @angela-tran Please review the updated i18n dev docs https://github.com/cal-itp/benefits/pull/1447/files#diff-739a6fd0a2d16786a1fad0499fde882753fee93043bb1f8b1a4b03ba5c75ea06 I tried covering all the new processes, but let me know if I'm missing anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit about an internal link, but otherwise this is great and I'd say let's get it published!
Co-authored-by: Kegan Maher <kegan@compiler.la>
closes #1446
What this PR does
Process