Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Veterans - Enrollment Success: Add msgid for Veterans copy #1464

Merged
merged 2 commits into from Jun 29, 2023
Merged

Fix: Veterans - Enrollment Success: Add msgid for Veterans copy #1464

merged 2 commits into from Jun 29, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 28, 2023 •
edited

fix #1463

  • Corrects the enrollment_success_confirm_item_details value for Veteran's EligibilityVerifier
  • Uses Enrollment Success copy from what is on Production and already translated - not what is on Figma currently for the time being. Updating the Enrollment Success copy with the new variables is not part of this ticket.
image

@machikoyasuda machikoyasuda self-assigned this Jun 28, 2023
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates i18n Copy: Language files or Django i18n framework and removed back-end Django views, sessions, middleware, models, migrations etc. labels Jun 28, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review June 28, 2023 23:47
@machikoyasuda machikoyasuda requested a review from a team as a code owner June 28, 2023 23:47
angela-tran
angela-tran reviewed Jun 29, 2023
View reviewed changes
benefits/locale/es/LC_MESSAGES/django.po
"No se le ha cobrado nada hoy. Al abordar al el tránsito, pague con esta "
"misma tarjeta física y automáticamente recibirá su nueva tarifa reducida. "
"Deberá volver a presenter la solicitud si elige cambiar la tarjeta bancaria "
"que utiliza para pagar el servicio de transito."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this entry (enrollment.pages.success.veteran.confirm_item.details) is the same content as enrollment.pages.success.login_gov.confirm_item.details. We know that we'll be working on copy more next sprint, so this fix will do for the scope of this sprint.

angela-tran
angela-tran reviewed Jun 29, 2023
View reviewed changes
benefits/core/migrations/0002_data.py
enrollment_success_confirm_item_details=_(
"enrollment.pages.index.login_gov.eligibility_confirmed_item.details%(transit_agency_short_name)s"
),
enrollment_success_confirm_item_details=_("enrollment.pages.success.veteran.confirm_item.details"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this msgid was what needed to be fixed.

@machikoyasuda machikoyasuda merged commit ed0d818 into dev Jun 29, 2023
11 checks passed
@machikoyasuda machikoyasuda deleted the fix/1462-veterans--elig-verifier-msgid branch June 29, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Veterans: Enrollment Success - Add correct msgid
2 participants
@machikoyasuda @angela-tran